[Samples] Move react-scripts to devDependencies
#4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
cwhitten
approved these changes
Aug 25, 2021
compulim
added a commit
to compulim/BotFramework-WebChat
that referenced
this pull request
Sep 9, 2021
* Move react-scripts in samples to devDependencies * Move react-scripts to devDependencies * Bump deps on samples * Bump http-proxy-middleware * Add entry * Update entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
react-scriptstodevDependencies, in PR #4023@azure/storage-blob@12.7.0base64-arraybuffer@1.0.1http-proxy-middleware@1.3.1restify@8.5.1Description
In our sample and playground, move
react-scriptstodevDependenciesto reduce omissions on vulnerabilities, as suggested by React team.As long as we don't
npm run eject, it should be good.Also bumping other dependencies in samples.
Design
As mentioned by React team, move
react-scriptstodevDependencieswill reduce some omissions.Specific Changes
npm install --dev react-scripts@lateston all playground and samples which based oncreate-react-appI have added tests and executed them locally(relies on CI)CHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)